Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick 8f56310fae4e1ad9d262b33e05dbcd5393f0e67c and aba6f6f4433d1f29986ec2c190e8c50628748f1a into 1.8 #11052

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Cherry pick 8f56310fae4e1ad9d262b33e05dbcd5393f0e67c and aba6f6f4433d1f29986ec2c190e8c50628748f1a into 1.8 #11052

merged 3 commits into from
Nov 22, 2023

Conversation

banool
Copy link
Contributor

@banool banool commented Nov 22, 2023 •
edited
Loading

@banool banool changed the base branch from main to aptos-release-v1.8 November 22, 2023 17:08
@banool banool changed the base branch from aptos-release-v1.8 to bowu/aptos-release-v1.8 November 22, 2023 17:11
@banool banool changed the base branch from bowu/aptos-release-v1.8 to aptos-release-v1.8 November 22, 2023 17:12
@areshand areshand enabled auto-merge (rebase) November 22, 2023 19:13
@areshand areshand disabled auto-merge November 22, 2023 19:15
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@sherry-x sherry-x enabled auto-merge (squash) November 22, 2023 23:08
@sherry-x sherry-x force-pushed the banool/cherry-pick-inc-4252 branch from c6a20b5 to 3d01ec2 Compare November 22, 2023 23:08
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.7.3 ==> 511eee6338a48ba915c5d35f7f27dba152976673

Compatibility test results for aptos-node-v1.7.3 ==> 511eee6338a48ba915c5d35f7f27dba152976673 (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 5356 txn/s, latency: 6219 ms, (p50: 6500 ms, p90: 9300 ms, p99: 9900 ms), latency samples: 187460
2. Upgrading first Validator to new version: 511eee6338a48ba915c5d35f7f27dba152976673
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1816 txn/s, latency: 15925 ms, (p50: 18600 ms, p90: 22300 ms, p99: 22500 ms), latency samples: 92620
3. Upgrading rest of first batch to new version: 511eee6338a48ba915c5d35f7f27dba152976673
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1857 txn/s, latency: 15663 ms, (p50: 18700 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 92880
4. upgrading second batch to new version: 511eee6338a48ba915c5d35f7f27dba152976673
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3244 txn/s, latency: 9390 ms, (p50: 10200 ms, p90: 12500 ms, p99: 13300 ms), latency samples: 136280
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 511eee6338a48ba915c5d35f7f27dba152976673 passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 511eee6338a48ba915c5d35f7f27dba152976673

two traffics test: inner traffic : committed: 6108 txn/s, latency: 6415 ms, (p50: 6000 ms, p90: 8400 ms, p99: 14400 ms), latency samples: 2651100
two traffics test : committed: 100 txn/s, latency: 2625 ms, (p50: 2400 ms, p90: 3000 ms, p99: 9200 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.242, avg: 0.213", "QsPosToProposal: max: 0.322, avg: 0.184", "ConsensusProposalToOrdered: max: 0.651, avg: 0.616", "ConsensusOrderedToCommit: max: 0.521, avg: 0.502", "ConsensusProposalToCommit: max: 1.166, avg: 1.119"]
Max round gap was 1 [limit 4] at version 1172235. Max no progress secs was 3.498245 [limit 10] at version 1172235.
Test Ok

@sherry-x sherry-x merged commit e29906e into aptos-release-v1.8 Nov 22, 2023
40 checks passed
@sherry-x sherry-x deleted the banool/cherry-pick-inc-4252 branch November 22, 2023 23:55
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> 511eee6338a48ba915c5d35f7f27dba152976673

Compatibility test results for aptos-node-v1.7.3 ==> 511eee6338a48ba915c5d35f7f27dba152976673 (PR)
Upgrade the nodes to version: 511eee6338a48ba915c5d35f7f27dba152976673
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4840 txn/s, latency: 6780 ms, (p50: 6800 ms, p90: 9600 ms, p99: 12700 ms), latency samples: 174260
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 511eee6338a48ba915c5d35f7f27dba152976673 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gedigi gedigi gedigi approved these changes

@areshand areshand areshand approved these changes

@alinush alinush Awaiting requested review from alinush

@msmouse msmouse Awaiting requested review from msmouse

@lightmark lightmark Awaiting requested review from lightmark

@JoshLind JoshLind Awaiting requested review from JoshLind JoshLind is a code owner

@bchocho bchocho Awaiting requested review from bchocho

@gregnazario gregnazario Awaiting requested review from gregnazario gregnazario is a code owner

@0xmaayan 0xmaayan Awaiting requested review from 0xmaayan 0xmaayan is a code owner

@0xmigo 0xmigo Awaiting requested review from 0xmigo

@davidiw davidiw Awaiting requested review from davidiw

@bowenyang007 bowenyang007 Awaiting requested review from bowenyang007

@jillxuu jillxuu Awaiting requested review from jillxuu

@larry-aptos larry-aptos Awaiting requested review from larry-aptos

@rtso rtso Awaiting requested review from rtso

@sasha8 sasha8 Awaiting requested review from sasha8

@gelash gelash Awaiting requested review from gelash

@zekun000 zekun000 Awaiting requested review from zekun000

@ibalajiarun ibalajiarun Awaiting requested review from ibalajiarun

@movekevin movekevin Awaiting requested review from movekevin

@danielxiangzl danielxiangzl Awaiting requested review from danielxiangzl

@junkil-park junkil-park Awaiting requested review from junkil-park

@wrwg wrwg Awaiting requested review from wrwg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@banool @areshand @gedigi @sherry-x @perryjrandall